On Wed, 2014-04-02 at 00:43 +0300, Or Gerlitz wrote: > On 18/03/2014 10:28, Or Gerlitz wrote: > > So I see these build warnings with isert, the 2nd one introduced with > > the T10 patches, Sagi, please take a look. The 1st one is harder to > > fix, I'm not sure it would be wise to just (void) the return value of > > isert_rx_opcode(), Nic? > > > > So the 2nd one was real bug that Sagi fixed, Nic, what about the 1st > one, any insight what needs to be done there? > Mmmm, with v3.12 pre-allocation of iscsi_cmd, the allocation in isert_rx_opcode() will never fail here.. So it should be safe to go ahead and remove the propagation of the return value up from isert_rx_opcode(). --nab > > CC [M] drivers/infiniband/ulp/isert/ib_isert.o > > drivers/infiniband/ulp/isert/ib_isert.c: In function ?isert_rx_do_work?: > > drivers/infiniband/ulp/isert/ib_isert.c:1388: warning: variable ?rc? > > set but not used > > drivers/infiniband/ulp/isert/ib_isert.c: In function > > ?isert_completion_rdma_read?: > > drivers/infiniband/ulp/isert/ib_isert.c:1739: warning: variable ?ret? > > set but not used > > > -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
