Hi Martin,
On Tue, 2014-04-01 at 16:03 +0200, Martin Svec wrote:
> When compiled with CONFIG_DEBUG_SG set, uninitialized SGL leads
> to BUG() in compare_and_write_callback().
>
> Signed-off-by: Martin Svec <martin.svec@xxxxxxxx>
> ---
> drivers/target/target_core_sbc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c
> index 52ae54e..aa7d99b 100644
> --- a/drivers/target/target_core_sbc.c
> +++ b/drivers/target/target_core_sbc.c
> @@ -419,13 +419,14 @@ static sense_reason_t compare_and_write_callback(struct se_cmd *cmd)
> goto out;
> }
>
> - write_sg = kzalloc(sizeof(struct scatterlist) * cmd->t_data_nents,
> + write_sg = kmalloc(sizeof(struct scatterlist) * cmd->t_data_nents,
> GFP_KERNEL);
> if (!write_sg) {
> pr_err("Unable to allocate compare_and_write sg\n");
> ret = TCM_OUT_OF_RESOURCES;
> goto out;
> }
> + sg_init_table (write_sg, cmd->t_data_nents);
> /*
> * Setup verify and write data payloads from total NumberLBAs.
> */
Applied to target-pending/for-next, with a CC' to v3.12+ stable.
Thanks!
--nab
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
