On Thu, 2014-02-20 at 19:31 +0200, Sagi Grimberg wrote:
> Found in 0-DAY kernel build testing backend
>
> drivers/built-in.o: In function `__isert_send_completion':
> >> ib_isert.c:(.text+0x178dc6d): undefined reference to `__udivdi3'
> >> ib_isert.c:(.text+0x178dda9): undefined reference to `__udivdi3'
>
> Signed-off-by: Sagi Grimberg <sagig@xxxxxxxxxxxx>
> ---
> drivers/infiniband/ulp/isert/ib_isert.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
> index 2953572..ba6791d 100644
> --- a/drivers/infiniband/ulp/isert/ib_isert.c
> +++ b/drivers/infiniband/ulp/isert/ib_isert.c
> @@ -1690,8 +1690,8 @@ isert_completion_rdma_write(struct iser_tx_desc *tx_desc,
> se_cmd->pi_err = TCM_LOGICAL_BLOCK_APP_TAG_CHECK_FAILED;
> break;
> }
> - se_cmd->bad_sector =
> - mr_status.sig_err.sig_err_offset / block_size;
> + se_cmd->bad_sector = mr_status.sig_err.sig_err_offset;
> + do_div(se_cmd->bad_sector, block_size);
>
> pr_err("isert: PI error found type %d at sector 0x%llx "
> "expected 0x%x vs actual 0x%x\n",
> @@ -1745,8 +1745,8 @@ isert_completion_rdma_read(struct iser_tx_desc *tx_desc,
> se_cmd->pi_err = TCM_LOGICAL_BLOCK_APP_TAG_CHECK_FAILED;
> break;
> }
> - se_cmd->bad_sector =
> - mr_status.sig_err.sig_err_offset / block_size;
> + se_cmd->bad_sector = mr_status.sig_err.sig_err_offset;
> + do_div(se_cmd->bad_sector, block_size);
>
> pr_err("isert: PI error found type %d at sector 0x%llx "
> "expected 0x%x vs actual 0x%x\n",
Verified this resolves the 32-bit division error with make modules
ARCH=i386, and applied + squashed into commit:
IB/isert: Support T10-PI protected transactions
Thanks Sagi!
--nab
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
