Re: [PATCH] IB/srpt: replace strict_strtoul() with kstrtoul()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2014-02-05 at 11:22 +0900, Jingoo Han wrote:
> The usage of strict_strtoul() is not preferred, because
> strict_strtoul() is obsolete. Thus, kstrtoul() should be
> used.
> 
> Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> ---

Applied to target-pending/queue.

Thanks!

--nab

>  drivers/infiniband/ulp/srpt/ib_srpt.c |   14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
> index 520a7e5..0e537d8 100644
> --- a/drivers/infiniband/ulp/srpt/ib_srpt.c
> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
> @@ -3666,9 +3666,9 @@ static ssize_t srpt_tpg_attrib_store_srp_max_rdma_size(
>  	unsigned long val;
>  	int ret;
>  
> -	ret = strict_strtoul(page, 0, &val);
> +	ret = kstrtoul(page, 0, &val);
>  	if (ret < 0) {
> -		pr_err("strict_strtoul() failed with ret: %d\n", ret);
> +		pr_err("kstrtoul() failed with ret: %d\n", ret);
>  		return -EINVAL;
>  	}
>  	if (val > MAX_SRPT_RDMA_SIZE) {
> @@ -3706,9 +3706,9 @@ static ssize_t srpt_tpg_attrib_store_srp_max_rsp_size(
>  	unsigned long val;
>  	int ret;
>  
> -	ret = strict_strtoul(page, 0, &val);
> +	ret = kstrtoul(page, 0, &val);
>  	if (ret < 0) {
> -		pr_err("strict_strtoul() failed with ret: %d\n", ret);
> +		pr_err("kstrtoul() failed with ret: %d\n", ret);
>  		return -EINVAL;
>  	}
>  	if (val > MAX_SRPT_RSP_SIZE) {
> @@ -3746,9 +3746,9 @@ static ssize_t srpt_tpg_attrib_store_srp_sq_size(
>  	unsigned long val;
>  	int ret;
>  
> -	ret = strict_strtoul(page, 0, &val);
> +	ret = kstrtoul(page, 0, &val);
>  	if (ret < 0) {
> -		pr_err("strict_strtoul() failed with ret: %d\n", ret);
> +		pr_err("kstrtoul() failed with ret: %d\n", ret);
>  		return -EINVAL;
>  	}
>  	if (val > MAX_SRPT_SRQ_SIZE) {
> @@ -3793,7 +3793,7 @@ static ssize_t srpt_tpg_store_enable(
>  	unsigned long tmp;
>          int ret;
>  
> -	ret = strict_strtoul(page, 0, &tmp);
> +	ret = kstrtoul(page, 0, &tmp);
>  	if (ret < 0) {
>  		printk(KERN_ERR "Unable to extract srpt_tpg_store_enable\n");
>  		return -EINVAL;


--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux