On Mon, 2014-01-20 at 14:23 +0200, Or Gerlitz wrote: > Hi Nic, > > Wanted to check with you re this 3.12.y commit 1094841 "ib_isert: Avoid > duplicate iscsit_increment_maxcmdsn call", is this really needed for e.g > for LTS distro code which is based on 3.10.y ?! what would be the > impact of running without it? > So iscsit_increment_maxcmdsn() was already ensuring that a MaxCmdSN increment happens only once per iscsi_cmd, so it was a cosmetic change and probably should not have been CC'ed for v3.12.y. > The sort of critical fix 82452e2 "iscsi-target: Fix mutex_trylock usage > in iscsit_increment_maxcmdsn" is in 3.10.y, so just wanted to check how > important is the other one. > ... > Also, how challenging would it be to back-port the following TEXT > related fixes from 3.11 to 3.10.y?once done, would it allow to > rundiscovery through iser on 3.10.y? > > ca40d24 iser-target: Ignore non TEXT + LOGOUT opcodes for discovery > adb54c2 iser-target: Add support for ISCSI_OP_TEXT opcode + payload > handling > 9864ca9 iscsi-target: Move sendtargets parsing into iscsit_process_text_cmd > dbf738a iscsi-target: Allow ->MaxXmitDataSegmentLength assignment for > iser discovery > 889c8a6 iscsi-target: Refactor ISCSI_OP_TEXT_RSP TX handling > 64534aa iscsi-target: Refactor ISCSI_OP_TEXT RX handling > 778de36 iscsi/isert-target: Refactor ISCSI_OP_NOOP RX handling > Backporting these is most likely straight forward, but as they don't meet the typical criteria (eg: they don't fix a bug), I'm weary of including them in v3.10.y kernels. --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
