Hi Eric,
On Thu, 2013-11-21 at 14:49 -0800, Eric Seppanen wrote:
> The iSCSI CHAP auth parameters are already copied with respect for
> the destination buffer size. Return -EINVAL instead of silently
> truncating the input.
>
> Signed-off-by: Eric Seppanen <eric@xxxxxxxxxxxxxxx>
> ---
> drivers/target/iscsi/iscsi_target_configfs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/target/iscsi/iscsi_target_configfs.c b/drivers/target/iscsi/iscsi_target_configfs.c
> index fd14525..de03cb3 100644
> --- a/drivers/target/iscsi/iscsi_target_configfs.c
> +++ b/drivers/target/iscsi/iscsi_target_configfs.c
> @@ -474,7 +474,8 @@ static ssize_t __iscsi_##prefix##_store_##name( \
> \
> if (!capable(CAP_SYS_ADMIN)) \
> return -EPERM; \
> - \
> + if (count >= sizeof(auth->name)) \
> + return -EINVAL; \
> snprintf(auth->name, sizeof(auth->name), "%s", page); \
> if (!strncmp("NULL", auth->name, 4)) \
> auth->naf_flags &= ~flags; \
Applied to queue, and will include into the first round of for-3.13-rc
fixes.
Thanks!
--nab
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
