On Tue, 2013-11-19 at 16:28 -0800, Roland Dreier wrote: > On Tue, Nov 19, 2013 at 3:16 PM, Nicholas A. Bellinger > <nab@xxxxxxxxxxxxxxx> wrote: > > So I've already applied the following patch to drop the locks for > > statistics, and use atomic_long_t for this particular items here: > > > > iscsi-target: Convert iscsi_session statistics to atomic_long_t > > https://git.kernel.org/cgit/linux/kernel/git/nab/target-pending.git/commit/?h=for-next&id=3e07395441c8b44e661572d33d3f06d249b48fb2 > > > > Also FYI, these particular values are exposed via > > drivers/target/target_core_stat.c, and not directly by > > iscsi_target_stat.c code. > > I think you mean > https://git.kernel.org/cgit/linux/kernel/git/nab/target-pending.git/commit/?h=for-next&id=f2f1dbf84bf6b18d8c3111c9d9078d9a2bf27ca0 > ("target/iscsi-target: Convert se_node_acl statistics to atomic_long_t") > > But that patch is pretty silly ... the fact that you are able to > change the type of those members of struct se_node_acl without > changing any code that actually reads the values and still have > everything compile should be a clue that maybe those values aren't > being used. > > So I think my patch makes a lot more sense than the patch that I > linked to above. > > But I'm happy to respin my patch on top of your pending tree if you > want (ie delete the new version of members instead of the old). No thanks, I'll just drop f2f1dbf8 above and apply this patch. --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
