Hello Nab,
Doug (on CC) asked me to try ddpt[1] on the target code and it failed
because list_id was 1. The linux target code expects it to be 0. Doug
did not like the sense code sent back:
> * drivers/target/target_core_xcopy.c line 907
> > sense_reason_t target_do_xcopy(struct se_cmd *se_cmd)
> > ...
> > list_id = p[0];
> > if (list_id != 0x00) {
> > pr_err("XCOPY with non zero list_id: 0x%02x\n",
> > list_id);
> > goto out;
> > }
> > ...
> > out:
> > if (p)
> > transport_kunmap_data_sg(se_cmd);
> > kfree(xop);
> > return TCM_INVALID_CDB_FIELD;
> > }
* Douglas Gilbert <dgilbert@xxxxxxxxxxxx> [2013-10-06 19:37]:
> With SCSI sense data the target should:
> a) give the correct ASC/ASCQ code "Invalid field in parameter list"
> b) point to the byte (and bit within that byte)
> that it objects to (and also say whether that
> byte is cdb or parameter list).
I assume you want that fixed. I wonder if you want it to fix by
yourself, or if I should do a proposal. Please let me know.
Howto reproduce:
I setup an iscsi-target in demo mode with 2 100 MB LUNs:
set global auto_cd_after_create=false
/backstores/fileio create shared-01.v101.campusvl.de /iscsi1/shared-01.v101.campusvl.de size=100M buffered=true
/backstores/fileio create shared-02.v101.campusvl.de /iscsi2/shared-02.v101.campusvl.de size=100M buffered=true
/iscsi create iqn.2013-03.de.campusvl.v101.storage:shared-01.v101.campusvl.de
/iscsi/iqn.2013-03.de.campusvl.v101.storage:shared-01.v101.campusvl.de/tpgt1/portals create 10.100.4.62
/iscsi/iqn.2013-03.de.campusvl.v101.storage:shared-01.v101.campusvl.de/tpgt1/luns create /backstores/fileio/shared-01.v101.campusvl.de lun=10
/iscsi/iqn.2013-03.de.campusvl.v101.storage:shared-01.v101.campusvl.de/tpgt1/ set attribute authentication=0 demo_mode_write_protect=0 generate_node_acls=1 cache_dynamic_acls=1
/iscsi create iqn.2013-03.de.campusvl.v101.storage:shared-02.v101.campusvl.de
/iscsi/iqn.2013-03.de.campusvl.v101.storage:shared-02.v101.campusvl.de/tpgt1/portals create 10.100.4.62
/iscsi/iqn.2013-03.de.campusvl.v101.storage:shared-02.v101.campusvl.de/tpgt1/luns create /backstores/fileio/shared-02.v101.campusvl.de lun=20
/iscsi/iqn.2013-03.de.campusvl.v101.storage:shared-02.v101.campusvl.de/tpgt1/ set attribute authentication=0 demo_mode_write_protect=0 generate_node_acls=1 cache_dynamic_acls=1
saveconfig
yes
Than I installed open-iscsi and configured it:
apt-get install open-iscsi
/etc/init.d/open-iscsi restart
iscsiadm -m discovery -t sendtargets -p 10.100.4.62
iscsiadm -m node --login
src/ddpt if=/dev/sg2 bs=512 of=/dev/sg3 iflag=xcopy
[1] http://sg.danny.cz/sg/
Cheers,
Thomas
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
