Hello Nab,
* Thomas Glanzmann <thomas@xxxxxxxxxxxx> [2013-10-04 21:56]:
> > +EXPORT_SYMBOL(core_tpg_get_initiator_node_acl);
> The patch I was sending you yesterday did _not_ compile because the
> prototype for core_tpg_get_initiator_node_acl was missing. I added the
> following line to the patch:
> diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
> index 1330045..504b5b5 100644
> --- a/drivers/target/iscsi/iscsi_target.c
> +++ b/drivers/target/iscsi/iscsi_target.c
> @@ -47,6 +47,8 @@
> #include "iscsi_target_device.h"
> #include "iscsi_target_stat.h"
> +#include "../target_core_internal.h"
> During testing yesterday I had this line in, however for submitting the patch I
> somehow thought it was a relict that I no longer needed so I removed the line
> before submitting the patch to you, which was of course wrong. I readded the
> line. Please let me know if this line is okay for you or if put the prototype
> for core_tpg_get_initiator_node_acl in another header file or want it defined
> manually?
I was able to answer that question by myself. I should move the
prototype from drivers/target/target_core_internal.h to
include/target/target_core_fabric.h similiar to
core_tpg_check_initiator_node_acl which is already global.
I did the same find v3 of the patchset below. Moving patch 2 to patch 3
and make core_tpg_get_initiator_node_acl global in patch2. patch1 stays
unmodified.
patch 3 also drops the +#include "../target_core_internal.h" line.
Cheers,
Thomas
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
