On Tue, Sep 10, 2013 at 03:51:50PM -0700, Nicholas A. Bellinger wrote:
> diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c
> index 2572ba7..6c17295 100644
> --- a/drivers/target/target_core_sbc.c
> +++ b/drivers/target/target_core_sbc.c
> @@ -504,12 +504,15 @@ sbc_compare_and_write(struct se_cmd *cmd)
> * comparision using SGLs at cmd->t_bidi_data_sg..
> */
> rc = down_interruptible(&dev->caw_sem);
> - if ((rc != 0) || signal_pending(current))
> + if ((rc != 0) || signal_pending(current)) {
> + cmd->transport_complete_callback = NULL;
> return TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE;
I think this needs to be separate:
if (rc) {
cmd->transport_complete_callback = NULL;
return TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE;
}
if (signal_pending(current)) {
up(&dev->caw_sem);
cmd->transport_complete_callback = NULL;
return TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE;
}
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
