On Tue, Aug 27, 2013 at 12:04 AM, kbuild test robot
<fengguang.wu@xxxxxxxxx> wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-next
> head: 0b67e68e2e8e0cb30ff1ea0698077cb4885d2e69
> commit: 4e5a22fa857f21a2914303f86127330a810eb1f7 [33/36] target: Add support for EXTENDED_COPY copy offload emulation
>
>
> sparse warnings: (new ones prefixed by >>)
>
>>> drivers/target/target_core_xcopy.c:1058:18: sparse: incorrect type in initializer (different base types)
> drivers/target/target_core_xcopy.c:1058:18: expected int [signed] rc
> drivers/target/target_core_xcopy.c:1058:18: got restricted sense_reason_t [usertype] <noident>
>>> drivers/target/target_core_xcopy.c:1071:20: sparse: incorrect type in assignment (different base types)
> drivers/target/target_core_xcopy.c:1071:20: expected int [signed] rc
> drivers/target/target_core_xcopy.c:1071:20: got restricted sense_reason_t
>>> drivers/target/target_core_xcopy.c:1081:16: sparse: incorrect type in return expression (different base types)
> drivers/target/target_core_xcopy.c:1081:16: expected restricted sense_reason_t
> drivers/target/target_core_xcopy.c:1081:16: got int [signed] rc
>
> vim +1058 drivers/target/target_core_xcopy.c
>
> 1052 }
> 1053
> 1054 sense_reason_t target_do_receive_copy_results(struct se_cmd *se_cmd)
> 1055 {
> 1056 unsigned char *cdb = &se_cmd->t_task_cdb[0];
> 1057 int sa = (cdb[1] & 0x1f), list_id = cdb[2];
>> 1058 int rc = TCM_NO_SENSE;
> 1059
> 1060 pr_debug("Entering target_do_receive_copy_results: SA: 0x%02x, List ID:"
> 1061 " 0x%02x, AL: %u\n", sa, list_id, se_cmd->data_length);
> 1062
> 1063 if (list_id != 0) {
> 1064 pr_err("Receive Copy Results with non zero list identifier"
> 1065 " not supported\n");
> 1066 return TCM_INVALID_CDB_FIELD;
> 1067 }
> 1068
> 1069 switch (sa) {
> 1070 case RCR_SA_OPERATING_PARAMETERS:
> 1071 rc = target_rcr_operating_parameters(se_cmd);
> 1072 break;
> 1073 case RCR_SA_COPY_STATUS:
> 1074 case RCR_SA_RECEIVE_DATA:
> 1075 case RCR_SA_FAILED_SEGMENT_DETAILS:
> 1076 default:
> 1077 pr_err("Unsupported SA for receive copy results: 0x%02x\n", sa);
> 1078 return TCM_INVALID_CDB_FIELD;
> 1079 }
> 1080
> 1081 return rc;
> 1082 }
>
Fixed.
Thanks Fengguang!
--nab
> ---
> 0-DAY kernel build testing backend Open Source Technology Center
> http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
