Hi Nic, Here are two small patches touching the iscsi sysfs store logic. The first is more important: it fixes a potential buffer overrun when storing the CHAP userid/password. The second patch is a little more subjective; it moves the post-store logic out to an explicit function, because I find it odd that auth->authenticate_target is updated even when unrelated sysfs strings are touched. Eric Seppanen (2): iscsi-target: clean up sysfs string store() macros. iscsi-target: separate post-sysfs-store functionality. drivers/target/iscsi/iscsi_target_configfs.c | 54 ++++++++++++++++---------- 1 file changed, 34 insertions(+), 20 deletions(-) -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html