On Mon, 2013-07-08 at 15:48 +0300, Or Gerlitz wrote: > On 08/07/2013 04:22, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx> > > > > Hi Or, > > > > Here are two more iser-target discovery related patches that I'm > > including into for-next code now.. > > Hi Nic, > > Using your tree for-next branch and the initiator patch I posted to the > open-iscsi list last week > I was able to have discovery going through iSER, cool. > > At some point I got the below trace I see it says "the code is fine but > needs lockdep annotation" > Hi Or, Thanks for reporting. I ran into this lockdep warning a while back, but have not had time to track it down yet. AFAICT it's a lock within cancel_work_sync() -> workqueue code that is triggering the warning. Will track this down soon. --nab > Or. > > > Set np->np_transport to ffffffffa037d0e0 -> iSCSI/TCP > Set np->np_transport to ffffffffa03af000 -> IB/iSER > lio_target_np_store_iser() done, op: 1 > target_core_get_fabric() failed for fc > target_core_get_fabric() failed for qla2xxx > MAD registration failed for mlx4_0-1. > srpt_add_one(mlx4_0) failed. > > i_buf: iqn.1994-05.com.redhat:308a2565a30, s_buf: Normal, t_buf: > iqn.2003-01.org.linux-iscsi.xena017-3.x8664:sn.796fc7cb211d > INFO: trying to register non-static key. > the code is fine but needs lockdep annotation. > turning off the locking correctness validator. > CPU: 0 PID: 4956 Comm: iscsi_trx Not tainted 3.10.0-rc5+ #4 > Hardware name: Red Hat KVM, BIOS 0.5.1 01/01/2007 > ffff88011ab6d8e0 ffff880102553918 ffffffff81480895 ffff8801025539b8 > ffffffff8109c6ed ffff88011ab6d8e0 0000000000000001 00000000007da260 > ffff880100000000 ffff880100000000 ffffffff00000000 0000000000000006 > Call Trace: > [<ffffffff81480895>] dump_stack+0x19/0x1c > [<ffffffff8109c6ed>] __lock_acquire+0x9bd/0xcf0 > [<ffffffff81098b64>] ? mark_held_locks+0xa4/0x140 > [<ffffffff8109ca78>] lock_acquire+0x58/0x70 > [<ffffffff8106b950>] ? cancel_delayed_work+0xa0/0xa0 > [<ffffffff8106b98a>] flush_work+0x3a/0x250 > [<ffffffff8106b950>] ? cancel_delayed_work+0xa0/0xa0 > [<ffffffff81098b64>] ? mark_held_locks+0xa4/0x140 > [<ffffffff8106be35>] ? __cancel_work_timer+0xc5/0x130 > [<ffffffff8106bdf7>] __cancel_work_timer+0x87/0x130 > [<ffffffff8106bebb>] cancel_work_sync+0xb/0x10 > [<ffffffffa03a845e>] isert_device_try_release+0x7e/0x130 [ib_isert] > [<ffffffffa03a86da>] isert_release_conn_kref+0x1ca/0x300 [ib_isert] > [<ffffffffa03a8838>] isert_put_conn+0x28/0x30 [ib_isert] > [<ffffffffa03a8951>] isert_free_conn+0x111/0x2d0 [ib_isert] > [<ffffffff81072ca0>] ? wake_up_bit+0x40/0x40 > [<ffffffffa0361636>] iscsit_close_connection+0x226/0x720 > [iscsi_target_mod] > [<ffffffffa0353738>] ? > iscsit_take_action_for_connection_exit+0xb8/0x100 [iscsi_target_mod] > [<ffffffffa0366de0>] ? iscsi_target_rx_opcode+0xc20/0xc20 > [iscsi_target_mod] > [<ffffffffa0366de0>] ? iscsi_target_rx_opcode+0xc20/0xc20 > [iscsi_target_mod] > [<ffffffffa0353740>] iscsit_take_action_for_connection_exit+0xc0/0x100 > [iscsi_target_mod] > [<ffffffffa0367077>] iscsi_target_rx_thread+0x297/0x380 [iscsi_target_mod] > [<ffffffff8107f833>] ? finish_task_switch+0x43/0x100 > [<ffffffff81483100>] ? __schedule+0x3b0/0xa00 > [<ffffffff81082008>] ? try_to_wake_up+0x208/0x300 > [<ffffffff81098ebd>] ? trace_hardirqs_on_caller+0xfd/0x1c0 > [<ffffffff81098f8d>] ? trace_hardirqs_on+0xd/0x10 > [<ffffffff81484f9d>] ? _raw_spin_unlock_irqrestore+0x3d/0x80 > [<ffffffffa0366de0>] ? iscsi_target_rx_opcode+0xc20/0xc20 > [iscsi_target_mod] > [<ffffffff81072716>] kthread+0xd6/0xe0 > [<ffffffff81072640>] ? __init_kthread_worker+0x70/0x70 > [<ffffffff81485c2c>] ret_from_fork+0x7c/0xb0 > [<ffffffff81072640>] ? __init_kthread_worker+0x70/0x70 > i_buf: iqn.1994-05.com.redhat:308a2565a30, s_buf: Normal, t_buf: > iqn.2003-01.org.linux-iscsi.xena017-3.x8664:sn.796fc7cb211d > i_buf: iqn.1994-05.com.redhat:308a2565a30, s_buf: Normal, t_buf: > iqn.2003-01.org.linux-iscsi.xena017-3.x8664:sn.796fc7cb211d > i_buf: iqn.1994-05.com.redhat:308a2565a30, s_buf: Normal, t_buf: > iqn.2003-01.org.linux-iscsi.xena017-3.x8664:sn.796fc7cb211d > i_buf: iqn.1994-05.com.redhat:308a2565a30, s_buf: Normal, t_buf: > iqn.2003-01.org.linux-iscsi.xena017-3.x8664:sn.796fc7cb211d > i_buf: iqn.1994-05.com.redhat:308a2565a30, s_buf: Normal, t_buf: > iqn.2003-01.org.linux-iscsi.xena017-3.x8664:sn.796fc7cb211d > i_buf: iqn.1994-05.com.redhat:308a2565a30, s_buf: Normal, t_buf: > iqn.2003-01.org.linux-iscsi.xena017-3.x8664:sn.796fc7cb211d > i_buf: iqn.1994-05.com.redhat:308a2565a30, s_buf: Normal, t_buf: > iqn.2003-01.org.linux-iscsi.xena017-3.x8664:sn.796fc7cb211d > -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
