On Mon, 2013-06-24 at 17:03 +0300, Dan Carpenter wrote:
> Hello Nicholas Bellinger,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch 291e29e02000: "iscsi/isert-target: Refactor ISCSI_OP_NOOP
> RX handling" from Jun 14, 2013, leads to the following Smatch
> complaint:
>
> drivers/target/iscsi/iscsi_target.c:1573 iscsit_setup_nop_out()
> error: we previously assumed 'cmd' could be null (see line 1572)
>
> drivers/target/iscsi/iscsi_target.c
> 1571 if (hdr->ttt == cpu_to_be32(0xFFFFFFFF)) {
> 1572 if (!cmd)
> ^^^
> cmd is NULL.
>
> 1573 return iscsit_add_reject_from_cmd(
> 1574 ISCSI_REASON_BOOKMARK_NO_RESOURCES,
> 1575 1, 0, (unsigned char *)hdr, cmd);
> ^^^
> iscsit_add_reject_from_cmd() will oops.
>
Hi Dan,
Dropping this dead code after the recent ISCSI_OP_NOOP refactoring, and
folding into for-next.
Thanks!
--nab
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
