On Fri, 2013-06-14 at 15:13 -0700, Nicholas A. Bellinger wrote: > Hi Or, > > Apologies for the delayed response.. > > On Wed, 2013-06-12 at 18:40 +0300, Or Gerlitz wrote: > > On 11/06/2013 15:26, Or Gerlitz wrote: > > > > > > Hi Nic, > > > > > > I saw that the TCP code is willing to handle TEXT/sendtargets from > > > within the kernel, so I went a head and added the patch below,I just > > > have to rush now to other venues and will be able to test that > > > tomorrow. Will that plus probably enhancing isert_response_queue too > > > be all, or you see anything which is missing here? > > > > > So the RX side text command handling needs to be converted to accept > struct iscsi_cmd, along with proper ISTATE_SEND_TEXTRSP state handling > for isert_response_queue() posting. > > > > > Running with this patch and attempting to issue discovery over iser, I > > came across this sequence of prints, can you let me > > know how to make things more verbose so I can maybe debug it up little > > further? > > > > > [ 1212.932724] i_buf: iqn.1994-05.com.redhat:e977fe6d73e, s_buf: > > > Discovery, t_buf: (null) > > > [ 1212.934862] Unable to accept text parameter length: 16greater than > > > MaxXmitDataSegmentLength 0. > > > > Mmmm, it looks like MXDSL assignment is getting skipped during discovery > session creation. > > Will fix up the TEXT/sendtargets over RDMA parts for v3.11, and have a > look at this bug soon.. > Hey Or, Here is a WIP to refactor TEXT RX/TX handling within iscsi-target, plus the associated ib_isert changes: http://git.kernel.org/cgit/linux/kernel/git/nab/target-pending.git/log/?h=queue This is compile tested only at the moment, but the conversion has been straightforward enough so far.. There is a bit more sendtargets parsing work to be done for v3.11 code, but this series should be (close to) functioning with SendTargets=All w/ the ib_iser initiator change. I'll get this finished up + post for review next week. Thanks! --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
