Hey Kent, So after rebasing target-tag-pool to include your percpu-tags v2 code from earlier this week, the BUG_ON(tag >= pool->nr_tags) below is immediately being triggered in the tcm_vhost response -> release path with a 4x tcm_vhost endpoint / ramdisk LUN + scsi-mq virtio-scsi client setup. lib/tags.c (v1) code is still running with the original target/tcm_vhost changes on v3.10-rc2, and AFAICT nothing changed on the target percpu-tags consumer side of things to cause this to occur.. Anything you'd like to see enabled for debugging this..? Thanks! --nab [ 192.119866] ------------[ cut here ]------------ [ 192.125026] kernel BUG at lib/percpu-tags.c:194! [ 192.130180] invalid opcode: 0000 [#1] SMP [ 192.134769] Modules linked in: vhost_scsi ib_srpt ib_cm ib_sa ib_mad ib_core tcm_qla2xxx tcm_loop tcm_fc libfc iscsi_target_mod target_core_pscsi target_core_file target_core_iblock target_core_mod configfs ipv6 iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi loop acpi_cpufreq freq_table mperf kvm_intel ehci_pci joydev button kvm crc32c_intel pcspkr i2c_i801 microcode ext3 jbd raid10 raid456 async_pq async_xor xor async_memcpy async_raid6_recov raid6_pq async_tx raid1 raid0 linear igb hwmon i2c_algo_bit i2c_core ptp ata_piix libata uhci_hcd ehci_hcd qla2xxx scsi_transport_fc scsi_tgt mlx4_core pps_core [ 192.195442] CPU: 5 PID: 3835 Comm: vhost-3821 Not tainted 3.10.0-rc5+ #127 [ 192.203118] Hardware name: Intel Corporation S5520HC/S5520HC, BIOS S5500.86B.01.00.0057.031020111721 03/10/2011 [ 192.214384] task: ffff880459c1aa00 ti: ffff880455c80000 task.ti: ffff880455c80000 [ 192.222740] RIP: 0010:[<ffffffff811a71d0>] [<ffffffff811a71d0>] percpu_tag_free+0x12/0xe0 [ 192.231982] RSP: 0018:ffff880455c81c58 EFLAGS: 00010086 [ 192.237912] RAX: ffff88045580c648 RBX: ffff880459e7fd40 RCX: 0000000180800051 [ 192.245879] RDX: 0000000180800000 RSI: 00000000ffffffff RDI: ffff880856099080 [ 192.253847] RBP: ffff880455c81c78 R08: 0000000000000001 R09: ffffea00215c8758 [ 192.261816] R10: ffffffffa0e03a3e R11: ffff88045dcb4000 R12: ffff880856099080 [ 192.269784] R13: ffff880459e7fcf8 R14: ffff880856099000 R15: ffff880455c81d98 [ 192.277752] FS: 0000000000000000(0000) GS:ffff88086fc40000(0000) knlGS:0000000000000000 [ 192.286788] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b [ 192.293203] CR2: 00007fdbfd287000 CR3: 000000045beff000 CR4: 00000000000027a0 [ 192.301169] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 192.309138] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 [ 192.317105] Stack: [ 192.319346] ffff880459e7fd40 0000000000000001 ffff880459e7fcf8 ffff880856099000 [ 192.327641] ffff880455c81ca8 ffffffffa0e03a69 ffff880856099068 ffff880459e7fd40 [ 192.335936] 0000000000000246 ffff880455c81e08 ffff880455c81cb8 ffffffffa0cf0489 [ 192.344232] Call Trace: [ 192.346964] [<ffffffffa0e03a69>] tcm_vhost_release_cmd+0x79/0x82 [vhost_scsi] [ 192.355036] [<ffffffffa0cf0489>] target_release_cmd_kref+0x7a/0x7c [target_core_mod] [ 192.363783] [<ffffffffa0cf14da>] target_put_sess_cmd+0x5f/0x7f [target_core_mod] [ 192.372144] [<ffffffffa0cf1881>] transport_release_cmd+0x53/0x57 [target_core_mod] [ 192.380689] [<ffffffffa0cf1953>] transport_put_cmd+0xce/0xda [target_core_mod] [ 192.388846] [<ffffffffa0cf19ad>] transport_generic_free_cmd+0x4e/0x52 [target_core_mod] [ 192.397884] [<ffffffffa0e0425d>] vhost_scsi_complete_cmd_work+0x13a/0x19b [vhost_scsi] [ 192.406824] [<ffffffffa0e058c6>] vhost_worker+0x149/0x171 [vhost_scsi] [ 192.414212] [<ffffffffa0e0577d>] ? vhost_dev_reset_owner+0x27/0x27 [vhost_scsi] [ 192.422473] [<ffffffffa0e0577d>] ? vhost_dev_reset_owner+0x27/0x27 [vhost_scsi] [ 192.430734] [<ffffffff81045f7d>] kthread+0xb0/0xb8 [ 192.436180] [<ffffffff81045ecd>] ? kthread_freezable_should_stop+0x60/0x60 [ 192.443959] [<ffffffff8138b22c>] ret_from_fork+0x7c/0xb0 [ 192.449985] [<ffffffff81045ecd>] ? kthread_freezable_should_stop+0x60/0x60 [ 192.457758] Code: 85 d2 75 0d 48 89 df e8 d3 fe ff ff b8 f4 ff ff ff 5a 5b 41 5c 41 5d c9 c3 55 48 89 e5 41 56 41 55 41 54 49 89 fc 53 3b 37 72 04 <0f> 0b eb fe 9c 41 5d fa 65 8b 3c 25 70 b0 00 00 49 8b 5c 24 08 [ 192.479413] RIP [<ffffffff811a71d0>] percpu_tag_free+0x12/0xe0 [ 192.486035] RSP <ffff880455c81c58> [ 192.489929] ---[ end trace 759c6e89282787ba ]--- [ 192.489934] ------------[ cut here ]------------ [ 192.489936] kernel BUG at lib/percpu-tags.c:194! [ 192.489938] invalid opcode: 0000 [#2] SMP [ 192.489962] Modules linked in: vhost_scsi ib_srpt ib_cm ib_sa ib_mad ib_core tcm_qla2xxx tcm_loop tcm_fc libfc iscsi_target_mod target_core_pscsi target_core_file target_core_iblock target_core_mod configfs ipv6 iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi loop acpi_cpufreq freq_table mperf kvm_intel ehci_pci joydev button kvm crc32c_intel pcspkr i2c_i801 microcode ext3 jbd raid10 raid456 async_pq async_xor xor async_memcpy async_raid6_recov raid6_pq async_tx raid1 raid0 linear igb hwmon i2c_algo_bit i2c_core ptp ata_piix libata uhci_hcd ehci_hcd qla2xxx scsi_transport_fc scsi_tgt mlx4_core pps_core [ 192.489965] CPU: 2 PID: 3832 Comm: vhost-3821 Tainted: G D 3.10.0-rc5+ #127 [ 192.489966] Hardware name: Intel Corporation S5520HC/S5520HC, BIOS S5500.86B.01.00.0057.031020111721 03/10/2011 [ 192.489967] task: ffff880459c19800 ti: ffff880457d72000 task.ti: ffff880457d72000 [ 192.489973] RIP: 0010:[<ffffffff811a71d0>] [<ffffffff811a71d0>] percpu_tag_free+0x12/0xe0 [ 192.489974] RSP: 0018:ffff880457d73c58 EFLAGS: 00010086 [ 192.489975] RAX: ffff88045740c648 RBX: ffff880459cffd40 RCX: 0000000180800032 [ 192.489975] RDX: 0000000180800000 RSI: 00000000ffffffff RDI: ffff880856099e80 [ 192.489976] RBP: ffff880457d73c78 R08: 0000000000000001 R09: ffffea001174fc58 [ 192.489977] R10: ffffffffa0e03a3e R11: ffff88045dcae000 R12: ffff880856099e80 [ 192.489978] R13: ffff880459cffcf8 R14: ffff880856099e00 R15: ffff880457d73d98 [ 192.489979] FS: 0000000000000000(0000) GS:ffff88045fc20000(0000) knlGS:0000000000000000 [ 192.489980] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b [ 192.489981] CR2: 00007fc234d22000 CR3: 000000045beff000 CR4: 00000000000027a0 [ 192.489981] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 192.489982] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 [ 192.489982] Stack: [ 192.489984] ffff880459cffd40 0000000000000001 ffff880459cffcf8 ffff880856099e00 [ 192.489985] ffff880457d73ca8 ffffffffa0e03a69 ffff880856099e68 ffff880459cffd40 [ 192.489986] 0000000000000246 ffff880457d73e08 ffff880457d73cb8 ffffffffa0cf0489 [ 192.489987] Call Trace: [ 192.489991] [<ffffffffa0e03a69>] tcm_vhost_release_cmd+0x79/0x82 [vhost_scsi] [ 192.490000] [<ffffffffa0cf0489>] target_release_cmd_kref+0x7a/0x7c [target_core_mod] [ 192.490005] [<ffffffffa0cf14da>] target_put_sess_cmd+0x5f/0x7f [target_core_mod] [ 192.490009] [<ffffffffa0cf1881>] transport_release_cmd+0x53/0x57 [target_core_mod] [ 192.490013] [<ffffffffa0cf1953>] transport_put_cmd+0xce/0xda [target_core_mod] [ 192.490018] [<ffffffffa0cf19ad>] transport_generic_free_cmd+0x4e/0x52 [target_core_mod] [ 192.490020] [<ffffffffa0e0425d>] vhost_scsi_complete_cmd_work+0x13a/0x19b [vhost_scsi] [ 192.490023] [<ffffffffa0e058c6>] vhost_worker+0x149/0x171 [vhost_scsi] [ 192.490025] [<ffffffffa0e0577d>] ? vhost_dev_reset_owner+0x27/0x27 [vhost_scsi] [ 192.490027] [<ffffffffa0e0577d>] ? vhost_dev_reset_owner+0x27/0x27 [vhost_scsi] [ 192.490031] [<ffffffff81045f7d>] kthread+0xb0/0xb8 [ 192.490033] [<ffffffff81045ecd>] ? kthread_freezable_should_stop+0x60/0x60 [ 192.490037] [<ffffffff8138b22c>] ret_from_fork+0x7c/0xb0 [ 192.490039] [<ffffffff81045ecd>] ? kthread_freezable_should_stop+0x60/0x60 [ 192.490051] Code: 85 d2 75 0d 48 89 df e8 d3 fe ff ff b8 f4 ff ff ff 5a 5b 41 5c 41 5d c9 c3 55 48 89 e5 41 56 41 55 41 54 49 89 fc 53 3b 37 72 04 <0f> 0b eb fe 9c 41 5d fa 65 8b 3c 25 70 b0 00 00 49 8b 5c 24 08 [ 192.490053] RIP [<ffffffff811a71d0>] percpu_tag_free+0x12/0xe0 [ 192.490053] RSP <ffff880457d73c58> [ 192.490055] ---[ end trace 759c6e89282787bb ]--- -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
