Re: [PATCH 04/13] target: Only return 0 or -err from core_scsi3_check_implicit_release

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2013-05-15 at 17:36 -0700, Andy Grover wrote:
> Caller doesn't need to differentiate between "nothing to release" and
> "successfully released" cases.
> 
> Signed-off-by: Andy Grover <agrover@xxxxxxxxxx>
> ---
>  drivers/target/target_core_pr.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/target/target_core_pr.c b/drivers/target/target_core_pr.c
> index c797e79..c89a33e 100644
> --- a/drivers/target/target_core_pr.c
> +++ b/drivers/target/target_core_pr.c
> @@ -1196,7 +1196,7 @@ static int core_scsi3_check_implict_release(
>  		 *    field set to zero (see 5.7.11.3).
>  		 */
>  		__core_scsi3_complete_pro_release(dev, nacl, pr_reg, 0);
> -		ret = 1;
> +		ret = 0;
>  		/*
>  		 * For 'All Registrants' reservation types, all existing
>  		 * registrations are still processed as reservation holders

NAK.  Look closer, core_scsi3_emulate_pro_register() uses this return
value to know when to send unit attentions to other REGONLY
registrations.

--nab



--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux