Hi Nicholas,
The commands' serial numbers which are 32bit quantities are expected to
wrap around and therefore in
"drivers/target/iscsi/iscsi_target_util.c::iscsit_check_received_cmdsn"
the macro "iscsi_sna_gt" is used to correctly check if the received
command serial number is in range.
However in "iscsit_attach_ooo_cmdsn" when inserting an OOO request is
inserted to what supposed to be an ordered link list
"sess_ooo_cmdsn_list" a "regular arithmetic" comparison is used without
taking the wrap around issue into account. That is "ooo_tail->cmdsn <
ooo_cmdsn->cmdsn", shouldn't it be "iscsi_sna_lt(ooo_tail->cmdsn,
ooo_cmdsn->cmdsn)" ?
Please advice.
Best regards,
S.P.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
