On Tue, 2013-04-30 at 11:59 -0700, Andy Grover wrote:
> User tools need to know if the device is properly configured, since if
> not, some other attributes are invalid.
>
> Signed-off-by: Andy Grover <agrover@xxxxxxxxxx>
> ---
> drivers/target/target_core_configfs.c | 11 +++++++++--
> 1 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
> index 43b7ac6..4a8bd36 100644
> --- a/drivers/target/target_core_configfs.c
> +++ b/drivers/target/target_core_configfs.c
> @@ -1584,6 +1584,13 @@ static struct target_core_configfs_attribute target_core_attr_dev_udev_path = {
> .store = target_core_store_dev_udev_path,
> };
>
> +static ssize_t target_core_show_dev_enable(void *p, char *page)
> +{
> + struct se_device *dev = p;
> +
> + return snprintf(page, PAGE_SIZE, "%d\n", !!(dev->dev_flags & DF_CONFIGURED));
> +}
Dropping the unnecessary !! here, and applying to queue.
--nab
> +
> static ssize_t target_core_store_dev_enable(
> void *p,
> const char *page,
> @@ -1609,8 +1616,8 @@ static ssize_t target_core_store_dev_enable(
> static struct target_core_configfs_attribute target_core_attr_dev_enable = {
> .attr = { .ca_owner = THIS_MODULE,
> .ca_name = "enable",
> - .ca_mode = S_IWUSR },
> - .show = NULL,
> + .ca_mode = S_IRUGO | S_IWUSR },
> + .show = target_core_show_dev_enable,
> .store = target_core_store_dev_enable,
> };
>
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
