On Thu, 2013-04-25 at 15:04 -0700, Andy Grover wrote:
> Some were incremented, but never used anywhere from what I could tell.
>
> Signed-off-by: Andy Grover <agrover@xxxxxxxxxx>
> ---
Once upon a time ->deve_cmds was used to aid in active I/O shutdown, but
as you've noticed this is no longer used.
Applying to target-pending/queue.
--nab
> drivers/target/target_core_device.c | 14 --------------
> drivers/target/target_core_internal.h | 1 -
> drivers/target/target_core_transport.c | 2 --
> include/target/target_core_base.h | 4 ----
> 4 files changed, 0 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
> index 2e4d655..4630481 100644
> --- a/drivers/target/target_core_device.c
> +++ b/drivers/target/target_core_device.c
> @@ -68,7 +68,6 @@ transport_lookup_cmd_lun(struct se_cmd *se_cmd, u32 unpacked_lun)
> struct se_dev_entry *deve = se_cmd->se_deve;
>
> deve->total_cmds++;
> - deve->total_bytes += se_cmd->data_length;
>
> if ((se_cmd->data_direction == DMA_TO_DEVICE) &&
> (deve->lun_flags & TRANSPORT_LUNFLAGS_READ_ONLY)) {
> @@ -85,8 +84,6 @@ transport_lookup_cmd_lun(struct se_cmd *se_cmd, u32 unpacked_lun)
> else if (se_cmd->data_direction == DMA_FROM_DEVICE)
> deve->read_bytes += se_cmd->data_length;
>
> - deve->deve_cmds++;
> -
> se_lun = deve->se_lun;
> se_cmd->se_lun = deve->se_lun;
> se_cmd->pr_res_key = deve->pr_res_key;
> @@ -275,17 +272,6 @@ int core_free_device_list_for_node(
> return 0;
> }
>
> -void core_dec_lacl_count(struct se_node_acl *se_nacl, struct se_cmd *se_cmd)
> -{
> - struct se_dev_entry *deve;
> - unsigned long flags;
> -
> - spin_lock_irqsave(&se_nacl->device_list_lock, flags);
> - deve = se_nacl->device_list[se_cmd->orig_fe_lun];
> - deve->deve_cmds--;
> - spin_unlock_irqrestore(&se_nacl->device_list_lock, flags);
> -}
> -
> void core_update_device_list_access(
> u32 mapped_lun,
> u32 lun_access,
> diff --git a/drivers/target/target_core_internal.h b/drivers/target/target_core_internal.h
> index 853bab6..18d49df 100644
> --- a/drivers/target/target_core_internal.h
> +++ b/drivers/target/target_core_internal.h
> @@ -8,7 +8,6 @@ extern struct t10_alua_lu_gp *default_lu_gp;
> struct se_dev_entry *core_get_se_deve_from_rtpi(struct se_node_acl *, u16);
> int core_free_device_list_for_node(struct se_node_acl *,
> struct se_portal_group *);
> -void core_dec_lacl_count(struct se_node_acl *, struct se_cmd *);
> void core_update_device_list_access(u32, u32, struct se_node_acl *);
> int core_enable_device_list_for_node(struct se_lun *, struct se_lun_acl *,
> u32, u32, struct se_node_acl *, struct se_portal_group *);
> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
> index f8388b4..c3477fa 100644
> --- a/drivers/target/target_core_transport.c
> +++ b/drivers/target/target_core_transport.c
> @@ -2163,8 +2163,6 @@ void transport_generic_free_cmd(struct se_cmd *cmd, int wait_for_tasks)
> if (wait_for_tasks)
> transport_wait_for_tasks(cmd);
>
> - core_dec_lacl_count(cmd->se_sess->se_node_acl, cmd);
> -
> if (cmd->se_lun)
> transport_lun_remove_cmd(cmd);
>
> diff --git a/include/target/target_core_base.h b/include/target/target_core_base.h
> index c4af592..136b7b2 100644
> --- a/include/target/target_core_base.h
> +++ b/include/target/target_core_base.h
> @@ -572,12 +572,8 @@ struct se_dev_entry {
> bool def_pr_registered;
> /* See transport_lunflags_table */
> u32 lun_flags;
> - u32 deve_cmds;
> u32 mapped_lun;
> - u32 average_bytes;
> - u32 last_byte_count;
> u32 total_cmds;
> - u32 total_bytes;
> u64 pr_res_key;
> u64 creation_time;
> u32 attach_count;
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
