On Fri, 2013-04-12 at 10:58 -0700, Andy Grover wrote: > On 04/11/2013 09:57 PM, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxxxxxxxx> > > > > Hi folks, > > > > This series adds support to rtslib for handling of the new iser-target > > attribute within the NetworkPortal class used by existing iscsi-target > > code. > > Hi Nick, > > Reviewing this, I noticed this comment at iscsi_target_configfs.c:305 > > /* > * Assume ISCSI_TCP by default. Other network portals for other > * iSCSI fabrics: > * > * Traditional iSCSI over SCTP (initial support) > * iSER/TCP (TODO, hardware available) > * iSER/SCTP (TODO, software emulation with osc-iwarp) > * iSER/IB (TODO, hardware available) > * > * can be enabled with attributes under > * sys/kernel/config/iscsi/$IQN/$TPG/np/$IP:$PORT/ > * > */ > > And indeed, the 'iser' attribute joins 'sctp' under the np entry. > > Are there really plans to support all these other options? Just TCP and > iSER/TCP transport support (plus all the other fabrics!) seems good > enough, from my POV. > >From iscsi-target's control plane perspective, all flavors of iser-target (IB/RoCE/iWARP) will be treated the same regardless of underlying transport. So that said, I'll be removing the unused legacy cruft to the contrary. --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
