On Wed, 2013-04-03 at 10:04 +0300, Or Gerlitz wrote: > On 02/04/2013 09:18, Or Gerlitz wrote: > > On 23/03/2013 01:55, Nicholas A. Bellinger wrote: > >> +++ b/drivers/infiniband/ulp/isert/isert_verbs.h > >> @@ -0,0 +1,5 @@ > >> +extern void isert_connect_release(struct isert_conn *); > >> +extern void isert_put_conn(struct isert_conn *); > >> +extern int isert_cma_handler(struct rdma_cm_id *, struct > >> rdma_cm_event *); > >> +extern int isert_post_recv(struct isert_conn *, u32); > >> +extern int isert_post_send(struct isert_conn *, struct iser_tx_desc *); > > > > why use extern here? maybe a left over from V1? > > Nic, are you picking this comment one and its sister comment asking to > remove externs and use less header files? > So in yesterday's target-pending/iser-target-wip push, source/headers have been merged into a single ib_isert.[c,h], with the exception of the existing isert_proto.h definitions. This will be included as a single commit for RFC-v3. --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
