Hi Jeff,
On Sat, 2013-03-23 at 17:18 -0700, Jeff Leung wrote:
> Unfortunately I learned that the hard way
> > >
> > > This will be easier said that done, given the number of locations that
> > > the sense_reason_t conversion patch ended up changing.. ;)
> > >
> >
> Would it be possible to checkout the sources from the 3.7.y branch and apply > it to the 3.8.y branch in the meantime?
>
> > > Great, thanks for verifying this is indeed a >= v3.8 regression.
> > >
> > > Thank you,
> > >
> > > --nab
Apologies for the delayed follow-up on this.
I just sent out a patch to address this regression, and have verified on
my end that the PR-OUT PREEMPT case you reported works as expected now
using v3.9-rc3 code with the following bugfix in place:
diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index 2030b60..3243ea7 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -1139,8 +1139,10 @@ target_setup_cmd_from_cdb(struct se_cmd *cmd, unsigned char *cdb)
return ret;
ret = target_check_reservation(cmd);
- if (ret)
+ if (ret) {
+ cmd->scsi_status = SAM_STAT_RESERVATION_CONFLICT;
return ret;
+ }
ret = dev->transport->parse_cdb(cmd);
if (ret)
Please verify on your side using v3.8.x or v3.9-rcX code with this
patch, and I'll push this to mainline for v3.9-rc5 ASAP.
Thank you again for your detailed bug report!
--nab
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
