Re: [PATCH 3/3] target/iscsi: Fix mutual CHAP auth on big-endian arches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2013-03-04 at 13:52 -0800, Andy Grover wrote:
> See https://bugzilla.redhat.com/show_bug.cgi?id=916290
> 
> Used a temp var since we take its address in sg_init_one.
> 
> Signed-off-by: Andy Grover <agrover@xxxxxxxxxx>
> ---

Applied to master queue, and including a CC' to stable here.

Thanks Andy!

--nab

>  drivers/target/iscsi/iscsi_target_auth.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/target/iscsi/iscsi_target_auth.c b/drivers/target/iscsi/iscsi_target_auth.c
> index b104c49..cee1754 100644
> --- a/drivers/target/iscsi/iscsi_target_auth.c
> +++ b/drivers/target/iscsi/iscsi_target_auth.c
> @@ -140,6 +140,7 @@ static int chap_server_compute_md5(
>  {
>  	char *endptr;
>  	unsigned long id;
> +	unsigned char id_as_uchar;
>  	unsigned char digest[MD5_SIGNATURE_SIZE];
>  	unsigned char type, response[MD5_SIGNATURE_SIZE * 2 + 2];
>  	unsigned char identifier[10], *challenge = NULL;
> @@ -329,7 +330,9 @@ static int chap_server_compute_md5(
>  		goto out;
>  	}
>  
> -	sg_init_one(&sg, &id, 1);
> +	/* To handle both endiannesses */
> +	id_as_uchar = id;
> +	sg_init_one(&sg, &id_as_uchar, 1);
>  	ret = crypto_hash_update(&desc, &sg, 1);
>  	if (ret < 0) {
>  		pr_err("crypto_hash_update() failed for id\n");


--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux