Re: [PATCH] target: Add link_magic for fabric allow_link destination target_items

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2013-02-04 at 16:49 -0800, Andy Grover wrote:
> On 12/04/2012 11:50 PM, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
> >
> > This patch adds [dev,lun]_link_magic value assignment + checks within generic
> > target_fabric_port_link() and target_fabric_mappedlun_link() code to ensure
> > destination config_item *target_item sent from configfs_symlink() ->
> > config_item_operations->allow_link() is the underlying se_device->dev_group
> > and se_lun->lun_group that we expect to symlink.
> 
> Regression. Attempting to add a storage object to a target results in 
> user process (targetcli) segfaulting.
> 
> This occurs when trying to create a the symlink from:
> /sys/kernel/config/target/core/rd_mcp_0/foo
> 
> to:
> /sys/kernel/config/target/loopback/naa.5001405e26e34ae4/tpgt_1/lun/lun_0/c180cd96bf
> 
> with the last bit being randomly generated by targetcli, as it has 
> always done afaict.
> 
> This is in stable 3.7.4, CCing stable@.
> 

Unfortunately this is a regression in stable due to the reordering of
se_device access after the upstream removal of struct se_subsystem_dev
during configfs fabric port link. :(

Greg-KH has queued this fix this for v3.7.6.  (CAI CC'ed)

Thanks,

--nab





--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux