On Mon, 2012-12-17 at 09:53 +0100, Hannes Reinecke wrote:
> The compiler complained about uninitialized variables, so
> use TCM_NO_SENSE here.
>
> Signed-off-by: Hannes Reinecke <hare@xxxxxxx>
> Cc: Nicholas Bellinger <nab@xxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/target/target_core_alua.c | 2 +-
> drivers/target/target_core_pr.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/target/target_core_alua.c b/drivers/target/target_core_alua.c
> index 85140f7..7d4ec02 100644
> --- a/drivers/target/target_core_alua.c
> +++ b/drivers/target/target_core_alua.c
> @@ -212,7 +212,7 @@ target_emulate_set_target_port_groups(struct se_cmd *cmd)
> struct t10_alua_tg_pt_gp_member *tg_pt_gp_mem, *l_tg_pt_gp_mem;
> unsigned char *buf;
> unsigned char *ptr;
> - sense_reason_t rc;
> + sense_reason_t rc = TCM_NO_SENSE;
> u32 len = 4; /* Skip over RESERVED area in header */
> int alua_access_state, primary = 0;
> u16 tg_pt_id, rtpi;
> diff --git a/drivers/target/target_core_pr.c b/drivers/target/target_core_pr.c
> index e35dbf8..8e0290b 100644
> --- a/drivers/target/target_core_pr.c
> +++ b/drivers/target/target_core_pr.c
> @@ -2053,7 +2053,7 @@ core_scsi3_emulate_pro_register(struct se_cmd *cmd, u64 res_key, u64 sa_res_key,
> /* Used for APTPL metadata w/ UNREGISTER */
> unsigned char *pr_aptpl_buf = NULL;
> unsigned char isid_buf[PR_REG_ISID_LEN], *isid_ptr = NULL;
> - sense_reason_t ret;
> + sense_reason_t ret = TCM_NO_SENSE;
> int pr_holder = 0, type;
>
> if (!se_sess || !se_lun) {
So these two should be initialized to '0' instead of the unnecessary
TCM_NO_SENSE define..
--nab
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
