Re: [PATCH 1/2] target: remove useless INIT_LIST_HEAD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/08/2012 03:12 AM, Nicholas A. Bellinger wrote:
Yes, I'd like to see this included in the patch ahead of a
target-pending/for-next merge.

I *tried* to audit all members, wrote a small list of the member and
the container(s) it uses and found two list_heads with no users besides
the INIT_LIST_HEAD(). I know that this is not even close to the memory
over commit I posted earlier but it is something :)


I don't disagree with the value of this path, but at this point the
for-3.8 diffstat is looking pretty large:

  47 files changed, 2778 insertions(+), 3977 deletions(-)

So given what's in flight now for v3.8, let's hold off one this until it
can more testing before heading to mainline, OK..?

Ah, this might be a misunderstanding :) I did not want to try to get
this merged for the v3.8 merge window. The code should be ready and
tested before getting merged and this is clearly not the case here. So
if you consider this for v3.9 it all good. I wouldn't even cry if you
would prefer to drop this but dropping it because you feel safer in
case you forget an init after converting element <-> container sounded
a little strange :)

--nab

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux