Re: [PATCH] target/tcm_fc: fix the lockdep warning due to inconsistent lock state

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 6, 2012 at 3:15 PM, Yi Zou <yi.zou@xxxxxxxxx> wrote:
> --- a/drivers/target/tcm_fc/tfc_sess.c
> +++ b/drivers/target/tcm_fc/tfc_sess.c
> @@ -226,8 +226,10 @@ static struct ft_sess *ft_sess_create(struct ft_tport *tport, u32 port_id,
>
>         pr_debug("port_id %x sess %p\n", port_id, sess);
>
> +       local_bh_disable();
>         transport_register_session(&tport->tpg->se_tpg, &acl->se_node_acl,
>                                    sess->se_sess, sess);
> +       local_bh_enable();
>         return sess;
>  }

This doesn't seem like the right fix to me.  I think
transport_deregister_session()
doesn't expect to be called from softirq context, and so the right fix is to
rearrange things so tcm_fc isn't doing that.  (ie defer to process context)

 - R.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux