On 11/13/12 2:22 PM, "Nicholas A. Bellinger" <nab@xxxxxxxxxxxxxxx> wrote:
>On Tue, 2012-11-13 at 18:41 +0000, Prantis, Kelsey wrote:
>> On 11/13/12 12:38 AM, "Nicholas A. Bellinger" <nab@xxxxxxxxxxxxxxx>
>>wrote:
>> >diff --git a/drivers/target/target_core_iblock.c
>> >b/drivers/target/target_core_iblock.c
>> >index 2782fa6..8718b74 100644
>> >--- a/drivers/target/target_core_iblock.c
>> >+++ b/drivers/target/target_core_iblock.c
>> >@@ -735,8 +735,13 @@ static void iblock_bio_done(struct bio *bio, int
>>err)
>> > err = -EIO;
>> >
>> > if (err != 0) {
>> >- pr_err("test_bit(BIO_UPTODATE) failed for bio: %p,"
>> >- " err: %d\n", bio, err);
>> >+ printk("test_bit(BIO_UPTODATE) failed for bio: %p
>>sector:
>> >%llu, bi_flags: 0x%16x"
>> >+ " bi_phys_segments: %u bi_vcnt: %hu bi_idx: %hu
>> >bi_max_vecs: %u"
>> >+ " err: %d\n", bio, bio->bi_sector,
>>bio->bi_flags,
>> >bi->bi_phys_segments,
>> >+ bio->bi_vcnt, bio->bi_idx, bio->bi_max_vecs,
>>err);
>> >+ printk("cmd: %p, CDB: 0x%02x data_length: %u t_data_sg:
>> >%p t_data_nents: %u\n",
>> >+ cmd, cmd->t_task_cdb[0], cmd->data_length,
>> >cmd->t_data_sg, cmd->t_data_nents);
>> >+ dump_stack();
>> > /*
>> > * Bump the ib_bio_err_cnt and release bio.
>> > */
>>
>> I wasn't able to build with this patch. I am receiving the following
>>error:
>>
>> drivers/target/target_core_iblock.c: In function 'iblock_bio_done':
>> drivers/target/target_core_iblock.c:747:54: error: 'bi' undeclared
>>(first
>> use in this function)
>> drivers/target/target_core_iblock.c:747:54: note: each undeclared
>> identifier is reported only once for each function it appears in
>>
>>
>> I'm guessing perhaps bi->bi_phys_segments is supposed to be
>> bio->bi_phys_segments? Will start building with that substitution, but
>> would appreciate if you could tell me if that is an incorrect
>>adjustment.
>>
>
>Whoops, apologies for the typo in the above debug patch. Your change is
>correct. :)
>
>Thanks,
>
>--nab
Hi Nicholas,
Sorry for the delay. The new debug output with your latest patch (and typo
adjustment) is up at ftp://ftp.whamcloud.com/uploads/lio-debug-4.txt.bz2
Kelsey
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
