On Thu, 2012-11-08 at 13:21 -0800, Nicholas A. Bellinger wrote: > On Thu, 2012-11-08 at 21:06 +0000, Prantis, Kelsey wrote: > > Hi Nicholas, > > > > I notice that the patch you submitted for this issue ([PATCH] > > target/iblock: Fix double iblock_complete_cmd callback bug) is a bit > > different from the latest included in this thread. Should we change over > > to that patch, or stick with what you provided us in this thread? > > > > Either one should work fine for your case. The latter one just drops > the extra iblock_submit_bios() call to avoid accounting issues during a > possible iblock_get_bio() allocation failure. > > Either one should work fine, as AFAICT from the logs your not getting > anywhere close to triggering the rolling iblock_submit_bios() call, or > returning non-zero from iblock_execute_rw(). > Hi Kelsey, Any luck with this patch..? I'm still testing the change but thus far it has been working as expected. I'd like to send this to Linus over the next days for v3.7-rc5 after a bit more testing (and with your Tested-by), so please let me know if you run into problems. Thanks, --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
