Re: [PATCH] target: Don't call spin_lock_irq() inside spin_lock_irqsave()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2012-10-31 at 10:24 -0700, Roland Dreier wrote:
> From: Steve Hodgson <steve@xxxxxxxxxxxxxxx>
> 
> Signed-off-by: Steve Hodgson <steve@xxxxxxxxxxxxxxx>
> Signed-off-by: Roland Dreier <roland@xxxxxxxxxxxxxxx>
> ---
> One more fix from Steve...
> 
>  drivers/target/target_core_tmr.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/target/target_core_tmr.c b/drivers/target/target_core_tmr.c
> index 1c59a3c..be75c43 100644
> --- a/drivers/target/target_core_tmr.c
> +++ b/drivers/target/target_core_tmr.c
> @@ -140,15 +140,15 @@ void core_tmr_abort_task(
>  		printk("ABORT_TASK: Found referenced %s task_tag: %u\n",
>  			se_cmd->se_tfo->get_fabric_name(), ref_tag);
>  
> -		spin_lock_irq(&se_cmd->t_state_lock);
> +		spin_lock(&se_cmd->t_state_lock);
>  		if (se_cmd->transport_state & CMD_T_COMPLETE) {
>  			printk("ABORT_TASK: ref_tag: %u already complete, skipping\n", ref_tag);
> -			spin_unlock_irq(&se_cmd->t_state_lock);
> +			spin_unlock(&se_cmd->t_state_lock);
>  			spin_unlock_irqrestore(&se_sess->sess_cmd_lock, flags);
>  			goto out;
>  		}
>  		se_cmd->transport_state |= CMD_T_ABORTED;
> -		spin_unlock_irq(&se_cmd->t_state_lock);
> +		spin_unlock(&se_cmd->t_state_lock);
>  
>  		list_del_init(&se_cmd->se_cmd_list);
>  		kref_get(&se_cmd->cmd_kref);

Applied to master + including in the next rc-fixes pull.

Thanks Steve & Co!

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux