On Wed, 2012-10-31 at 11:32 -0700, Nicholas A. Bellinger wrote:
> On Wed, 2012-10-31 at 12:07 -0600, Kelsey Prantis wrote:
> > Hi Nicholas,
> >
> > The kernel on the target server is 3.6.3-1.fc17.x86_64
> >
> > I have been playing with it trying to figure it out over the last day,
> > including removing the target and trying to recreate it, which all
> > ended in the same result. Here is the error message and 'sg_inq -i
> > /dev/sdX' output for that new target.
> >
> > Oct 30 21:35:06 hydra-2-ss-storage-appliance-1 udevd-work[21950]:
> > symlink(../../sda,
> > /dev/disk/by-id/scsi-30103ff1060014053a4c9495036c94f81ffffffff020100184c494f2d4f52470049424c4f434b3a3361346339343935005194ff04000000025195000408ab0000018eff04000000005398005069716e2e323030332d30312e6f72672e6c696e75782d69736373692e68796472612d322d646576696365732d686f73742e78.udev-tmp)
> > failed: File name too long
> >
> > [root@hydra-2-ss-storage-appliance-1 ~]# sg_inq -i /dev/sda
> > VPD INQUIRY: Device Identification page
> > Designation descriptor number 1, descriptor length: 20
> > designator_type: NAA, code_set: Binary
> > associated with the addressed logical unit
> > NAA 6, IEEE Company_id: 0x1405
> > Vendor Specific Identifier: 0x3a4c94950
> > Vendor Specific Identifier Extension: 0x36c94f81ffffffff
> > [0x60014053a4c9495036c94f81ffffffff]
> > Designation descriptor number 2, descriptor length: 28
> > designator_type: T10 vendor identification, code_set: ASCII
> > associated with the addressed logical unit
> > vendor id: LIO-ORG
> > vendor specific: IBLOCK:3a4c9495
> > Designation descriptor number 3, descriptor length: 8
> > transport: Internet SCSI (iSCSI)
> > designator_type: Relative target port, code_set: Binary
> > associated with the target port
> > Relative target port: 0x2
> > Designation descriptor number 4, descriptor length: 8
> > transport: Internet SCSI (iSCSI)
> > designator_type: Target port group, code_set: Binary
> > associated with the target port
> > Target port group: 0x0
> > Designation descriptor number 5, descriptor length: 8
> > designator_type: Reserved [0xe], code_set: Binary
> > associated with the addressed logical unit
> > 00 30 00 00 00 0...
>
> Thanks for the extra information.
>
> So I've seen something similar with INQUIRY EVPD=0x83 emulation using
> recent v3.7-rc2 code, but it looks like the same regression is effecting
> v3.6.x stable as well.
>
> I'm pretty sure this is regression related to the recent re-factoring of
> control CDB emulation logic, most likely that INQUIRY buffer allocations
> are no longer being explicitly zeroed with iscsi-target.
>
> Tracking down this item is currently on my short-term v3.7-rc TODO list,
> and I should have something for you in the next 24 hours.
>
Ok, so the culprit commit ffe7b0e932 went in during the v3.7-rc1
target-pending merge, and was also CC'ed to stable which explains why
3.6.3-1.fc17.x86_64 is also being effected by this regression..
commit ffe7b0e9326d9c68f5688bef691dd49f1e0d3651
Author: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Fri Sep 7 17:30:38 2012 +0200
target: support zero allocation length in INQUIRY
I've just pushed the bugfix to target-pending/master here:
http://git.kernel.org/?p=linux/kernel/git/nab/target-pending.git;a=commitdiff;h=dea5f0998aa82bdeca260b87c653db11e91329b2
and will be sending out to Linus for v3.7-rc4 w/ CC stable for v3.6.6 to
pickup.
Thanks again for reporting Kelsey!
--nab
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
