On Wed, 2012-10-10 at 10:46 -0400, Christoph Hellwig wrote: > On Tue, Oct 09, 2012 at 01:37:47PM -0700, Nicholas A. Bellinger wrote: > > ERROR: "spc_emulate_report_luns" [drivers/target/target_core_pscsi.ko] undefined! > > make[1]: *** [__modpost] Error 1 > > make: *** [modules] Error 2 > > > > Adding the missing EXPORT_SYMBOL for spc_emulate_report_luns to allow > > target_core_pscsi.c code to be built as a module. > > There's another bug in this one, spc_emulate_report_luns should not > be called directly but must be set as the execute_cmd callback. <nod> > Do you > want an incremental fixup or a resend of the patch with both the fixes? > An incremental fixup for the second item to squash into the original patch now in queue is fine. --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html