Re: [PATCH] target: kill struct se_subsystem_dev

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2012-10-08 at 00:03 -0400, Christoph Hellwig wrote:
> Simplify the code a lot by killing the superflous struct se_subsystem_dev.
> Instead se_device is allocated early on by the backend driver, which allocates
> it as part of its own per-device structure, borrowing the scheme that is for
> example used for inode allocation.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 

Applied to queue for the moment along with the other four follow-up
patches.

Considering the size of this one I'll need to spend some more time
reviewing, but from an initial scan the conversion to use se_device
universally looks quite solid.

Extremely nice work managing to squeeze another ~900 LOC out of the
backend device drivers !

> ---
>  drivers/target/loopback/tcm_loop.h           |    1 
>  drivers/target/target_core_alua.c            |  152 +++---
>  drivers/target/target_core_alua.h            |    4 
>  drivers/target/target_core_configfs.c        |  526 ++++++-----------------
>  drivers/target/target_core_device.c          |  613 +++++++++++++--------------
>  drivers/target/target_core_fabric_configfs.c |   14 
>  drivers/target/target_core_file.c            |  142 ++----
>  drivers/target/target_core_file.h            |    2 
>  drivers/target/target_core_hba.c             |    4 
>  drivers/target/target_core_iblock.c          |  187 +++-----
>  drivers/target/target_core_iblock.h          |    1 
>  drivers/target/target_core_internal.h        |   12 
>  drivers/target/target_core_pr.c              |  148 ++----
>  drivers/target/target_core_pr.h              |    2 
>  drivers/target/target_core_pscsi.c           |  272 ++++-------
>  drivers/target/target_core_pscsi.h           |    2 
>  drivers/target/target_core_rd.c              |   94 +---
>  drivers/target/target_core_rd.h              |    1 
>  drivers/target/target_core_sbc.c             |   31 -
>  drivers/target/target_core_spc.c             |   91 +---
>  drivers/target/target_core_stat.c            |  307 +++----------
>  drivers/target/target_core_tmr.c             |    6 
>  drivers/target/target_core_transport.c       |  217 ---------
>  drivers/target/target_core_ua.c              |    6 
>  include/target/target_core_backend.h         |   25 -
>  include/target/target_core_base.h            |  104 +---
>  26 files changed, 1052 insertions(+), 1912 deletions(-)
> 


--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux