Re: [PATCH 3/5] iscsit: add missing endianess conversion in iscsit_check_inaddr_any

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 26, 2012 at 09:08:36AM -0700, Roland Dreier wrote:
> On Wed, Sep 26, 2012 at 5:00 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> > Sparse noticed that INADDR_ANY needs to be converted to big endian before
> > it can be stored in struct sockaddr_in.s_addr.
> 
> A fine cleanup, but 0 is the same in any endianness ;)

But inaddr_any isn't 0, it is ((unsigned long int) 0x00000000), which
for sparse is annotate as native endian.  Maybe it's a bug in sparse
that the normal "0" special case isn't extended to it, but I'd rather
add the conversion that all other users have.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux