On Sun, 2012-08-26 at 14:22 -0400, Christoph Hellwig wrote: > On Thu, Aug 23, 2012 at 02:00:45AM +0000, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx> > > > > This patch adds the missing rd_mcp_template->write_cache_emulated=1 bit to > > optionally allow WriteCacheEnabled=1 (WCE) to be enabled for the built-in > > TCM/rd_mcp backend driver. > > Stupid question, but what do we even need this flag for? All emulated > frontends handles this entirely in the core, so that flag should simply > go away. > Yep, you're right. This flag was originally used to know when to -EINVAL from attribute code in target_core_device.c when userspace is incorrectly trying to enable emulation bits for pSCSI backends. The same is true here for ->fua_write_emulated code as well, so lets drop both of these se_subsystem-api bits in favor of an explicit check for TRANSPORT_PLUGIN_PHBA_PDEV with these two attributes. Sending out a patch shortly.. --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
