Re: [PATCH] target: Fix regression bug with handling of zero-length data CDBs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 17, 2012 at 12:16:13AM +0000, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
> 
> This patch fixes a regression bug with the handling of zero-length
> data CDBs within transport_generic_new_cmd() code.  The bug was introduced
> with the following commit as part of the single task conversion work:

Can you please send a patch for the SCSI testsuite that reproduces the
bug?

> +	/* Workaround for handling zero-length control+data CDBs */

I'd rather have a useful comment here, ala:

	/*
	 * If this command doesn't have any payload we are don't have
	 * to call into the fabric for data transfers but can complete
	 * it right away.
	 */

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux