On Wed, 2012-08-15 at 14:35 -0700, Roland Dreier wrote: > From: Roland Dreier <roland@xxxxxxxxxxxxxxx> > > Every fabric driver has to supply a se_tfo->set_fabric_sense_len() > method, just so iSCSI can return an offset of 2. However, every fabric > driver is already allocating a sense buffer and passing it into the > target core, either via transport_init_se_cmd() or target_submit_cmd(). > > So instead of having iSCSI pass the start of its sense buffer into the > core and then later tell the core to skip the first 2 bytes, it seems > easier for iSCSI just to do the offset of 2 when it passes the sense > buffer into the core. Then we can drop the se_tfo->set_fabric_sense_len() > everywhere, and just add a couple of lines of code to iSCSI to set the > sense data length to the beginning of the buffer right before it sends > it over the network. > > Signed-off-by: Roland Dreier <roland@xxxxxxxxxxxxxxx> > --- A nice simplification for the handling of SCSI sense buffer offset into a fabric response PDU data segment for this special iSCSI case ! Both patches look good, and will apply to -> for-next as soon as -rc2 is cut. Thanks Roland! --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
