[trimming CCs] [resurrecting old thread] On 05/31/2012 01:25 AM, Nicholas A. Bellinger wrote: > [PATCH-v2] target/file: Use O_DSYNC by default for FILEIO backends > > Convert to use O_DSYNC for all cases at FILEIO backend creation time to > avoid the extra syncing of pure timestamp updates with legacy O_SYNC during > default operation as recommended by hch. Continue to do this independently of > Write Cache Enable (WCE) bit, as WCE=0 is currently the default for all backend > devices and enabled by user on per device basis via attrib/emulate_write_cache. > > This patch drops the now unnecessary fd_buffered_io= token usage that was > originally signaling when to explicitly disable O_SYNC at backend creation > time for buffered I/O operation. This can end up being dangerous for a number > of reasons during physical node failure, so go ahead and drop this option > for now when O_DSYNC is used as the default. rtslib lets you specify buffered or unbuffered when creating backstores, and would set fd_buffered_io=1. Should it just set attrib/emulate_write_cache=1 now that fd_buffered_io=1 is gone? Or to ask another way: overall, how should this option be presented to the user? It seems rather important, and applies to both fileio and iblock. Thanks -- Regards -- Andy -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
