On Wed, 2012-07-18 at 02:11 +0300, Michael S. Tsirkin wrote: > On Tue, Jul 17, 2012 at 03:37:20PM -0700, Nicholas A. Bellinger wrote: > > On Wed, 2012-07-18 at 01:18 +0300, Michael S. Tsirkin wrote: > > > On Tue, Jul 17, 2012 at 03:02:08PM -0700, Nicholas A. Bellinger wrote: > > > > On Wed, 2012-07-18 at 00:34 +0300, Michael S. Tsirkin wrote: <SNIP> > > > > > > I don't see how it helps. The driver is either a guaranteed ABI or not. > > > I'd prefer not to have vhost users outside drivers/vhost/ since it is > > > harder for me to keep track of them. > > > > > > What's the problem with staging proposal? It's just another hoop to jump > > > through to enable it? > > > > > > > Yeah, I'm OK with just adding a CONFIG_STAGING tag is a reasonable step > > forward for-3.6. > > > > Adding the following patch into target-pending/for-next-merge now: > > > > diff --git a/drivers/vhost/Kconfig b/drivers/vhost/Kconfig > > index ccbeb6f..2cd7135 100644 > > --- a/drivers/vhost/Kconfig > > +++ b/drivers/vhost/Kconfig > > @@ -11,7 +11,7 @@ config VHOST_NET > > > > config TCM_VHOST > > tristate "TCM_VHOST fabric module (EXPERIMENTAL)" > > - depends on TARGET_CORE && EVENTFD && EXPERIMENTAL && m > > + depends on TARGET_CORE && EVENTFD && EXPERIMENTAL && STAGING && m > > default n > > ---help--- > > Say M here to enable the TCM_VHOST fabric module for use with virtio-scsi guests > > > > > > Hmm that's not explicit enough, someone might enable CONFIG_STAGING for > some other reason and won't notice the dependency. > We need it to appear with other staging drivers in the menu, > so there needs to be a Kconfig that is included from > drivers/staging/Kconfig. > Mmmmm, I am sensing a linux-next merge conflict with staging-next and/or another for-next-merge rebase coming on.. > For example, we can create > drivers/vhost/staging/Kconfig or drivers/vhost/tcm/Kconfig and include > it from drivers/staging/Kconfig. nouveau did something like this for a > while, see f3c93cbde7eab38671ae085cb1027b08f5f36757. > > No need to move the rest of the code. > OK, lets use drivers/vhost/tcm/Kconfig and I'll post a incremental patch to make it appear under staging it shortly. (CC'ing Greg-KH for good measure.) -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
