Hi Wu! On Wed, 2012-07-04 at 15:48 +0800, wfg@xxxxxxxxxxxxxxx wrote: > Hi Nicholas, > > There are new sparse warnings show up in > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git tcm_vhost > head: 5d79da8394584e86a30d718bc0b10278d2c9a939 > commit: b454f58bed99193cd150a31622455bf93aa7cfc5 [23/24] tcm_vhost: Initial merge for vhost level target fabric driver > > All sparse warnings: > > + drivers/vhost/tcm_vhost.c:68:31: sparse: symbol 'tcm_vhost_fabric_configfs' was not declared. Should it be static? > + drivers/vhost/tcm_vhost.c:71:1: sparse: symbol 'tcm_vhost_mutex' was not declared. Should it be static? > + drivers/vhost/tcm_vhost.c:72:1: sparse: symbol 'tcm_vhost_list' was not declared. Should it be static? > + drivers/vhost/tcm_vhost.c:120:5: sparse: symbol 'tcm_vhost_get_tag' was not declared. Should it be static? > > vim +68 drivers/vhost/tcm_vhost.c > 65 }; > 66 > 67 /* Local pointer to allocated TCM configfs fabric module */ > > 68 struct target_fabric_configfs *tcm_vhost_fabric_configfs; > 69 > 70 /* Global spinlock to protect tcm_vhost TPG list for vhost IOCTL access */ > 71 DEFINE_MUTEX(tcm_vhost_mutex); > > Please consider folding the attached diff :-) > Applied to target-pending/tcm_vhost, and will fold into the single commit merge when dropping tcm_vhost into for-next. Thank you! -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
