On Sat, 2012-05-26 at 11:31 +0100, Chris Boot wrote:
> On 24/05/2012 21:07, Stefan Richter wrote:
> > 'int login_id' shadows 'static atomic_t login_id'.
> > Seen as compilation warning on x86-32.
> >
> > Signed-off-by: Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx>
> > ---
> > drivers/target/sbp/sbp_target.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > --- a/drivers/target/sbp/sbp_target.c
> > +++ b/drivers/target/sbp/sbp_target.c
> > @@ -587,14 +587,14 @@ static void sbp_management_request_logou
> > {
> > struct sbp_tport *tport = agent->tport;
> > struct sbp_tpg *tpg = tport->tpg;
> > - int login_id;
> > + int id;
> > struct sbp_login_descriptor *login;
> >
> > - login_id = LOGOUT_ORB_LOGIN_ID(be32_to_cpu(req->orb.misc));
> > + id = LOGOUT_ORB_LOGIN_ID(be32_to_cpu(req->orb.misc));
> >
> > - login = sbp_login_find_by_id(tpg, login_id);
> > + login = sbp_login_find_by_id(tpg, id);
> > if (!login) {
> > - pr_warn("cannot find login: %d\n", login_id);
> > + pr_warn("cannot find login: %d\n", id);
> >
> > req->status.status = cpu_to_be32(
> > STATUS_BLOCK_RESP(STATUS_RESP_REQUEST_COMPLETE) |
> >
> >
>
> Looks good.
>
> Acked-by: Chris Boot <bootc@xxxxxxxxx>
>
Thanks Stefan + Chris! Applied to target-pending/3.5-merge-fixes.
--nab
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
