Resent without HTML, darn webmail client. ---------- Forwarded message ---------- From: Jerome Martin <jxm@xxxxxxxxxxxxxxxxxxxxx> Date: Thu, May 10, 2012 at 1:10 PM Subject: Re: feedback on your recent updates To: Andy Grover <agrover@xxxxxxxxxx> Cc: target-devel <target-devel@xxxxxxxxxxxxxxx> On Thu, May 10, 2012 at 8:51 AM, Andy Grover <agrover@xxxxxxxxxx> wrote: > > Hi, here's some constructive feedback on your recent rtslib update: > > - Instead of merging the new changes with nab's srpt fix, it looks like > there was a forced update? If you can avoid rebases, it saves followers > of your repo from also having to rebase. Yes, really sorry for that. Of course this is something I try to avoid. > > - I like the generic auth stuff, but the old code had handling for > reading/writing the special string "NULL" instead of empty strings. The > new code likely also needs this. > Thanks for reporting, I'll take a look at this ASAP. -- Jérôme Martin -- Jérôme Martin -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
