On Mon, 2012-05-07 at 15:41 -0400, Jörn Engel wrote: > Signed-off-by: Joern Engel <joern@xxxxxxxxx> > --- > drivers/scsi/qla2xxx/tcm_qla2xxx.c | 7 ++----- > 1 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c > index 5c9a07f..9946196 100644 > --- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c > +++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c > @@ -54,8 +54,8 @@ > #include "qla_target.h" > #include "tcm_qla2xxx.h" > > -extern struct workqueue_struct *tcm_qla2xxx_free_wq; > -extern struct workqueue_struct *tcm_qla2xxx_cmd_wq; > +struct workqueue_struct *tcm_qla2xxx_free_wq; > +struct workqueue_struct *tcm_qla2xxx_cmd_wq; > Ditto here.. checkpatch already caught this one.. > static int tcm_qla2xxx_check_true(struct se_portal_group *se_tpg) > { > @@ -750,9 +750,6 @@ static u16 tcm_qla2xxx_set_fabric_sense_len(struct se_cmd *se_cmd, u32 sense_len > struct target_fabric_configfs *tcm_qla2xxx_fabric_configfs; > struct target_fabric_configfs *tcm_qla2xxx_npiv_fabric_configfs; > > -struct workqueue_struct *tcm_qla2xxx_free_wq; > -struct workqueue_struct *tcm_qla2xxx_cmd_wq; > - > static int tcm_qla2xxx_setup_nacl_from_rport( > struct se_portal_group *se_tpg, > struct se_node_acl *se_nacl, Keeping this part to drop unnecessary prototypes for workqueue_struct Thanks Joern! --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html