On 04/05/2012 08:07 PM, Nicholas A. Bellinger wrote: > On Tue, 2012-04-03 at 15:51 -0700, Andy Grover wrote: >> This is so we can hoist it before se_cmd init in a later patch. Instead, >> pass it into build_pdu_and_seq_lists, and then stick it in the >> struct iscsi_build_list that gets passed around. >> > > This assumption is incorrect because target_setup_cmd_from_cdb() -> > transport_generic_cmd_sequencer() may end up changing > se_cmd->data_length if what the fabric declares for data_length does not > match what is extracted from SCSI CDB length at the bottom on the > sequencer code.. > > Which means that iscsit_build_pdu_and_seq_lists() cannot depend upon > this value until transport_generic_cmd_sequencer() has been called to > verify the two values. > > So given that fact, I'm not going to merge this one for now. Thanks for catching this. -- Andy -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
