On Wed, Apr 04, 2012 at 03:34:34PM -0700, Nicholas A. Bellinger wrote: > On Tue, 2012-04-03 at 15:51 -0700, Andy Grover wrote: > > Compiles fine with CONFIG_SMP=y or n. > > > > Signed-off-by: Andy Grover <agrover@xxxxxxxxxx> > > --- > > drivers/target/iscsi/iscsi_target.c | 20 -------------------- > > 1 files changed, 0 insertions(+), 20 deletions(-) > > > > diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c > > index 816baba..c9bf158 100644 > > --- a/drivers/target/iscsi/iscsi_target.c > > +++ b/drivers/target/iscsi/iscsi_target.c > > @@ -3416,8 +3416,6 @@ static void iscsit_tx_thread_wait_for_tcp(struct iscsi_conn *conn) > > } > > } > > > > -#ifdef CONFIG_SMP > > - > > Mmm, last time I checked on 2.6.x this worked on x86_64, but fails to > compile on arm CONFIG_SMP=n due to missing cpumask_set_cpu() and > set_cpus_allowed_ptr().. > > Arnd + Russel (Cc'ed), do you know if this is still the case that we > need CONFIG_SMP here..? No idea, first I've heard of that kind of report. It brings up the question why this file isn't including headers which are relevant for its compilation. For the two functions you mention, that's linux/cpumask.h and linux/sched.h, both of which are pretty standard kernel includes. I don't think this has anything specific to do with ARM. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
