Re: [PATCH] tcm_fc: Add abort flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2012-04-04 at 22:05 +0000, Rustad, Mark D wrote:
> On Apr 4, 2012, at 3:00 PM, Mark Rustad wrote:
> 
> > Add abort flag and use it to terminate processing when an exchange
> > is timed out or is reset. The abort flag is used in place of the
> > transport_generic_free_cmd function call in the reset and timeout
> > cases, because calling that function in that context would free
> > memory that was in use. The aborted flag allows the lifetime to
> > be managed in a more normal way, while truncating the processing.
> > 
> > This change eliminates a source of memory corruption which
> > manifested in a variety of ugly ways.
> > 
> > Signed-off-by: Mark Rustad <mark.d.rustad@xxxxxxxxx>
> > Acked-by: Kiran Patil <Kiran.patil@xxxxxxxxx>
> 
> I should have said more about this originally. This makes it clearer
> what the consequences of not having the patch are. And of course your
> earlier comment to me that transport_generic_free_cmd can't be used
> there was exactly right.
> 

<nod>

I'll apply the updated patch to target-pending/3.4-rc-fixes shortly and
get these queued to mainline for -rc2 -> -rc3.

Thanks again!

--nab




--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux