Re: DF_READ_ONLY obsolete?

["Nicholas A. Bellinger" <nab@xxxxxxxxxxxxxxx>]

On Tue, 2012-03-20 at 17:44 -0700, Roland Dreier wrote:
> Hi Nic,
> 

Hi Roland,

> Just noticed:
> 
> $ git grep DF_READ_ONLY
> drivers/target/target_core_device.c:    if (dev->dev_flags & DF_READ_ONLY)
> drivers/target/target_core_tpg.c:                       if
> (dev->dev_flags & DF_READ_ONLY)
> include/target/target_core_base.h:#define DF_READ_ONLY
>          0x00000001
> 
> is DF_READ_ONLY something obsolete we can kill off?
> 

This was used at one time as a hack by FILEIO backend registration to
allow a struct block_device that was claimed with blkdev_get (by a local
filesystem mount for example) to be exported as read-only (SCSI WP=1).

Since FILEIO backend registration will no longer attempt to obtain
exclusive access to an underlying struct block_device here, this flag is
obsolete.

Dropping it now with the following patch in lio-core.

Thanks!

--nab

diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index 755035f..a374cb5 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -1342,7 +1342,6 @@ struct se_lun *core_dev_add_lun(
        u32 lun)
 {
        struct se_lun *lun_p;
-       u32 lun_access = 0;
        int rc;
 
        if (atomic_read(&dev->dev_access_obj.obj_access_count) != 0) {
@@ -1355,12 +1354,8 @@ struct se_lun *core_dev_add_lun(
        if (IS_ERR(lun_p))
                return lun_p;
 
-       if (dev->dev_flags & DF_READ_ONLY)
-               lun_access = TRANSPORT_LUNFLAGS_READ_ONLY;
-       else
-               lun_access = TRANSPORT_LUNFLAGS_READ_WRITE;
-
-       rc = core_tpg_post_addlun(tpg, lun_p, lun_access, dev);
+       rc = core_tpg_post_addlun(tpg, lun_p,
+                               TRANSPORT_LUNFLAGS_READ_WRITE, dev);
        if (rc < 0)
                return ERR_PTR(rc);
 
diff --git a/drivers/target/target_core_tpg.c b/drivers/target/target_core_tpg.c
index 70c3ffb..c672a40 100644
--- a/drivers/target/target_core_tpg.c
+++ b/drivers/target/target_core_tpg.c
@@ -175,10 +175,7 @@ void core_tpg_add_node_to_devs(
                 * demo_mode_write_protect is ON, or READ_ONLY;
                 */
                if (!tpg->se_tpg_tfo->tpg_check_demo_mode_write_protect(tpg)) {
-                       if (dev->dev_flags & DF_READ_ONLY)
-                               lun_access = TRANSPORT_LUNFLAGS_READ_ONLY;
-                       else
-                               lun_access = TRANSPORT_LUNFLAGS_READ_WRITE;
+                       lun_access = TRANSPORT_LUNFLAGS_READ_WRITE;
                } else {
                        /*
                         * Allow only optical drives to issue R/W in default RO
diff --git a/include/target/target_core_base.h b/include/target/target_core_base.h
index 5ef4361..b571556 100644
--- a/include/target/target_core_base.h
+++ b/include/target/target_core_base.h
@@ -72,9 +72,8 @@
 /*
  * struct se_device->dev_flags
  */
-#define DF_READ_ONLY                           0x00000001
-#define DF_SPC2_RESERVATIONS                   0x00000002
-#define DF_SPC2_RESERVATIONS_WITH_ISID         0x00000004
+#define DF_SPC2_RESERVATIONS                   0x00000001
+#define DF_SPC2_RESERVATIONS_WITH_ISID         0x00000002
 
 /* struct se_dev_attrib sanity values */
 /* Default max_unmap_lba_count */



--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html