On Mon, 27 February 2012 23:10:12 -0800, Nicholas A. Bellinger wrote: > On Mon, 2012-02-27 at 15:45 -0500, Jörn Engel wrote: > > > In fact, there is no point in having the extra refcount at all anymore. > > AFAICT the extra refcount is still required for qla_tgt_sess creation > case in order to prevent an external kref_put(se_sess->sess_kref) from > configfs context dropping sess_kref to zero + releasing before > ->hardware_lock is done with qla_tgt_sess reference. You are right. The original reason, pointed out in the old comment, no longer applies. But if we still hold and use references, we better make sure we also still have a refcount to match. Jörn -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html