Re: [PATCH 0/5] target: Add se_session->sess_kref + convert iscsi/qla2xxx fabrics

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 27, 2012 at 11:51 PM, Nicholas A. Bellinger
<nab@xxxxxxxxxxxxxxx> wrote:
> tcm_fc currently uses it's own session referencing that can be converted
> to se_sess->sess_kref usage without too much effort.

...although current code looks similarly busted:

/*
 * Remove session and send PRLO.
 * This is called when the ACL is being deleted or queue depth is changing.
 */
void ft_sess_close(struct se_session *se_sess)

... so we have good intentions to log out initiator as the
comment says, but then the actual code ends with:

        ft_sess_put(sess);
        /* XXX Send LOGO or PRLO */

and afaics from tfc_sess.c it also suffers from the same
use-after-free on ACL removal as tcm_qla2xxx.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux